New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide option to disable internet connections #774
Conversation
Thank you very much for the code, but I'm afraid that there is still one step to get it work. I set > pkgdown::build_home()
── Building home ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
Reading 'news.md'
Writing 'index.html'
── Previewing site ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
> pkgdown::build_site()
══ Building pkgdown site ═══════════════════════════════════════════════════════════════════════════════════════════════════════════════════
Reading from: '/media/computer/work/R/hgnc'
Writing to: '/media/computer/work/R/hgnc/docs'
── Initialising site ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
Writing 'sitemap.xml'
● Edit '_pkgdown.yml'
── Building home ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
Reading 'news.md'
Error in curl::curl_fetch_memory(url, handle = handle) :
Could not resolve host: cloud.r-project.org
Calls: withCallingHandlers ... request_fetch.write_memory -> <Anonymous> -> .handleSimpleError -> h
Execution halted
Error in curl::curl_fetch_memory(url, handle = handle) :
Could not resolve host: cloud.r-project.org |
I found that In this scenario, I think it's quite intuitive to enable Otherwise, user have to run |
I think we need to add But then you have to set the option via |
Yeah, I think it's the natural way. |
I think it would be better to set the option explicitly in the new process |
How can you achieve that? Instead The only drawback is when user want to run some code in |
pkgdown would do it for you. Writing to |
If the user develops multiple packages, specify that in every Another way is to set it in |
Maybe we can have something like setup:
code: options(pkgdown.internet = F) or setup:
options:
pkgdown.internet: F |
👍 For me the builds now run through with:
⚡ But there are more problems ahead. Since internet is no option looking at the docs in a browser will result in several files the browser cannot obtain:
|
@petermeissner I know this way, the down point is that we have to run pkgdown in a dirty session. |
I think we might have gone so far. What I'm talking about originally is to disable internet for building the documentation, not for viewing the documentation. Maybe we need separate option for these two senarios. |
@jayhesselberth 56f3a65#r30192460
|
Closes #773. Closes #762. Closes #766.